Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BayerLuetticke should be a REMARK #531

Closed
llorracc opened this issue Feb 19, 2020 · 7 comments · Fixed by #603
Closed

BayerLuetticke should be a REMARK #531

llorracc opened this issue Feb 19, 2020 · 7 comments · Fixed by #603

Comments

@llorracc
Copy link
Collaborator

@sbenthall and @MridulS, could you coordinate on turning BayerLuetticke into a REMARK? And, @MridulS, we will want to be able to run both the OneAsset and the TwoAsset notebooks (or, really, their corresponding .py files) using your awesome Docker tool.

@sbenthall
Copy link
Contributor

This issue duplicates #361.

@sbenthall
Copy link
Contributor

Looking at the REMARK guidelines:

https://github.com/econ-ark/REMARK#remark-guidelines

It looks like the current BayerLuetticke code, which has 3 notebooks in it, would be an exceptional case to the REMARK standard, which has only one eponymous notebook.

How would you like the BL REMARK to be organized?

It would be easy enough to just copy the old code over, but I think if it's a true REMARK it may need to be structured differently.

@sbenthall
Copy link
Contributor

History of BayerLuetticke (before getting moved to Examples):
https://github.com/econ-ark/HARK/commits/0.10.2/HARK/BayerLuetticke

@sbenthall
Copy link
Contributor

Related to #570 ...

Is teh BayerLuetticke code written in a way that requires "backwards time"?

@llorracc
Copy link
Collaborator Author

No.

@llorracc
Copy link
Collaborator Author

For my last class in Oslo today, I decided to copy BayerLuetticke wholesale to the REMARK repo. I've made some small edits to it there, and from now on that should be considered the "master" version.

I agree that for it to be a proper REMARK it would need a bit of restructuring. In particular, it would need a do_all_code.sh script in the root directory. Will try to get to that.

@sbenthall
Copy link
Contributor

Oh, I just saw this comment.
If https://github.com/econ-ark/REMARK/tree/master/REMARKs/BayerLuetticke is not the canonical version of this, the the example/ version can be removed.

I'll do that in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants