-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BayerLuetticke "DCT-Copula-Illustration" requires seaborn, which is not installed #451
Comments
This is another example of our need to determine how to handle requirements. At the moment BayerLuetticke is in HARK so the relevant requirements would be those of Econ-ARK. But there is also a /binder file at the root level of HARK, which has a requirements.txt file that includes seaborn. So if you launch it as a mybinder notebook, the seaborn requirement is satisfied. Could you make a PR to update the econ-ark "master" requirements to include seaborn? It is so widely used that it should be available to users even if it is not invoked in any of the core code of HARK. |
I made a different case here before reading your comment: By the "econ-ark "master" requirements" I guess you mean the requirements of the installed This is in itself a bit confusing, since Econ-ARK refers to a larger project, if I'm not mistaken. |
I meant literally the requirements that are installed when you do a pip or conda install of econ-ark. At the moment, I believe those come from HARK, if you're not sure where they come from, I'm sure Shauna knows. |
Yeah |
@MridulS, why don't you go ahead and do that. I've asked Shauna to make a new release and we might as well get this in it. |
Done #454 @llorracc do we have a standard release cycle document somewhere? which ideally contains our standard procedure and a future schedule? something like https://github.com/networkx/networkx/blob/master/RELEASE.rst |
We don't have a standard release cycle; partly that's because the pace at
which releases that are "worth it" (in terms of having meaningful
improvements) comes very unevenly.
I could be persuaded that we should have a regular schedule, if that is
something that is viewed as good practice ...
…On Tue, Dec 10, 2019 at 5:43 PM Mridul Seth ***@***.***> wrote:
Done #454 <#454>
@llorracc <https://github.com/llorracc> do we have a standard release
cycle document somewhere? which ideally contains our standard procedure and
a future schedule?
something like
https://github.com/networkx/networkx/blob/master/RELEASE.rst
https://github.com/sympy/sympy/tree/master/release#release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#451?email_source=notifications&email_token=AAKCK75AQMJYLMZKFSWWSBTQYALSPA5CNFSM4JZABB5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGRHACA#issuecomment-564293640>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKCK7YESI2UZ5IA3EGBCU3QYALSPANCNFSM4JZABB5A>
.
--
- Chris Carroll
|
…used in docs). Fixes econ-ark#451" This reverts commit 2c21161.
Fixed with #454 |
@MridulS - release documentation is on the wiki: https://github.com/econ-ark/OverARK/wiki/Release-Management No future schedule though - we haven't been updating with enough frequency for that. |
The
DCT-Copula-Illustration
notebook in BayerLuetticke requires theseaborn
dependency, which is not in the requirements.The text was updated successfully, but these errors were encountered: