Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BayerLuetticke "DCT-Copula-Illustration" requires seaborn, which is not installed #451

Closed
sbenthall opened this issue Dec 10, 2019 · 9 comments

Comments

@sbenthall
Copy link
Contributor

The DCT-Copula-Illustration notebook in BayerLuetticke requires the seaborn dependency, which is not in the requirements.

@llorracc
Copy link
Collaborator

This is another example of our need to determine how to handle requirements. At the moment BayerLuetticke is in HARK so the relevant requirements would be those of Econ-ARK. But there is also a /binder file at the root level of HARK, which has a requirements.txt file that includes seaborn. So if you launch it as a mybinder notebook, the seaborn requirement is satisfied.

Could you make a PR to update the econ-ark "master" requirements to include seaborn? It is so widely used that it should be available to users even if it is not invoked in any of the core code of HARK.

@sbenthall
Copy link
Contributor Author

I made a different case here before reading your comment:
#442 (comment)

By the "econ-ark "master" requirements" I guess you mean the requirements of the installed econ-ark package, which are defined at the top level of the HARK repository?

This is in itself a bit confusing, since Econ-ARK refers to a larger project, if I'm not mistaken.

@llorracc
Copy link
Collaborator

By the "econ-ark "master" requirements" I guess you mean the requirements of the installed econ-ark package, which are defined at the top level of the HARK repository?

I meant literally the requirements that are installed when you do a pip or conda install of econ-ark. At the moment, I believe those come from HARK, if you're not sure where they come from, I'm sure Shauna knows.

@MridulS
Copy link
Member

MridulS commented Dec 10, 2019

Yeah pip install Econ-ark will install requirements from HARK, so we need to add Seaborn to requirements and setup.py for HARK.

@llorracc
Copy link
Collaborator

@MridulS, why don't you go ahead and do that. I've asked Shauna to make a new release and we might as well get this in it.

@MridulS
Copy link
Member

MridulS commented Dec 10, 2019

Done #454

@llorracc do we have a standard release cycle document somewhere? which ideally contains our standard procedure and a future schedule?

something like https://github.com/networkx/networkx/blob/master/RELEASE.rst
https://github.com/sympy/sympy/tree/master/release#release

@llorracc
Copy link
Collaborator

llorracc commented Dec 10, 2019 via email

sbenthall added a commit to sbenthall/HARK that referenced this issue Dec 11, 2019
@sbenthall
Copy link
Contributor Author

Fixed with #454

@shaunagm
Copy link
Contributor

@MridulS - release documentation is on the wiki:

https://github.com/econ-ark/OverARK/wiki/Release-Management
https://github.com/econ-ark/OverARK/wiki/Release-History

No future schedule though - we haven't been updating with enough frequency for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants