Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gentle Buffer Stock improvements #88

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Gentle Buffer Stock improvements #88

merged 6 commits into from
Feb 18, 2020

Conversation

sbenthall
Copy link
Contributor

Work on Gentle-Intro-To-HARK-Buffer-Stock-Model
Issue #87

…smetic edits; discrete distribution display
@sbenthall
Copy link
Contributor Author

@llorracc This PR is ready for your review.

I did change some things about parameters and inheritance.

Two things I haven't been able to move forward on:

  • The parameter inheritance does not yet make the most of the class inheritance between AgentTypes; I hope to do some more work on this. So what I included in this notebook is agnostic to the implementation of the parameter inheritance.
  • I am still struggling to understand exactly how the universal solver and its instantiations works. So instead of trying to explain it, I've introduced commands that allow the students to inspect the documentation themselves.

@sbenthall sbenthall changed the title [WIP] Gentle Buffer Stock improvements Gentle Buffer Stock improvements Feb 14, 2020
@sbenthall
Copy link
Contributor Author

@llorracc
Copy link
Collaborator

llorracc commented Feb 17, 2020 via email

@sbenthall
Copy link
Contributor Author

You can view the diff here: https://github.com/econ-ark/DemARK/pull/88/files

  • reduced the explicit parameters set in code to the necessary ones for the content
  • added sections about using dir() and __bases__ to better understand inheritance
  • added a visualization of the discretized shock distribution
  • added a section on the help() function in Python

@llorracc
Copy link
Collaborator

Sorry, I was unclear: Was asking what the difference was between the version you gave me a link to, and the one that is in the PR?

PS. When I test a "merge" I get a message that the branch has conflicts that must be resolved.

@sbenthall
Copy link
Contributor Author

The one I linked to and the one in the PR are identical.
The link and the PR point in different ways to the same repository, branch, and file.

I've fixed the merge conflicts just now.

@llorracc
Copy link
Collaborator

OK, got it, thanks.

Am just looking at it now.

  1. The "setup" cell still has %matplotinline.
    • I believe that this is no longer necessary, right?
  2. I like what you have done.
  3. But would like to expand the content a bit
    • In particular, you are more of a newcomer to HARK than I am
    • So the things that students might stumble over and need explained are fresher in your mind than mine
  4. You've spent some time reviewing both Karsten's notebook and Jan Rosa's.
    • Let's think of this notebook as prep material for one of those
    • If you look at those with an eye toward "what things might be good prep for these notebooks" am guessing you can quickly come up with a couple of things in addition to the point about how you have to reconstruct shocks.

@sbenthall
Copy link
Contributor Author

Ok, in the most recent commits I've:

  • removed the %matplotlib magic
  • added a section on backwards induction, which is an opportunity to discuss the Solution object and the functions within it, including an introduction of the linear interpolator used for the consumption function.

This sets up students for the discussion of the solver mechanics in the next lecture.

In general, I'd say the interpolation mechanics are one of the bigger surprises to me in the library; it's also clearly substantively important functionality. I'd like to surface it more in the documentation elsewhere as well.

@llorracc llorracc merged commit 2b0fa5a into econ-ark:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants