removing DEMARKs that are now in HARK/examples, fixes #81 #107
Conversation
|
@sbenthall odd, the checks failed -- I don't see why removing anything should cause checks to fail ... |
|
The failing tests are due to this PR in HARK I'll submit a different PR to peg the dependency to 0.10.4 |
|
Oh, I can put that change into this PR |
| @@ -4,7 +4,7 @@ python: | |||
| # command to install dependencies | |||
| install: | |||
| - pip install -r requirements.txt | |||
| - pip install git+https://github.com/econ-ark/HARK.git@master | |||
| - pip install git+https://github.com/econ-ark/HARK.git@0.10.4 | |||
There was a problem hiding this comment.
I’m not sure about this. Users will find this weird as DemARKs won’t be running with the latest HARK.
There was a problem hiding this comment.
Ah, I see. You have people using the binder/requirements.txt file in the install instructions.
I was confused because econ-ark is not in the requirements.txt file at the top level.
|
With the latest commit, those following the installation instructions will have working DemARKs. I am working on changes that will fix the DemARKs broken in this PR: econ-ark/HARK#527 But those changes are unrelated to this PR, which is about something else. |
|
Ok I'm going to add these removals to the PR for #109 |
No description provided.