Add support for diffs created with --no-prefix option #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was always wondering, why the first two characters of
RnDiffAppare cut when clicking on "view source" link. I have found out that GitHub provides diffs without git diff prefixes (a/, b/) and this library simply cuts the first two characters.I took the fast way and added
noPrefixflag to theparsemethod.We could also do it smarter way and detect the prefixes, but I do not think it is worth the effort as user of this library most probably knows how diff has been generated.
Cheers,
Dominik