Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fortran api init functions #165

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

sbrdar
Copy link
Collaborator

@sbrdar sbrdar commented Nov 21, 2023

Add Fortran API for initial functions util/function/MDPI_functions

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99207ce) 79.86% compared to head (a9ad0b0) 79.98%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
+ Coverage    79.86%   79.98%   +0.12%     
===========================================
  Files          849      851       +2     
  Lines        63076    63142      +66     
===========================================
+ Hits         50374    50505     +131     
+ Misses       12702    12637      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbrdar that will be useful for testing algorithms. Please address following issues.

src/tests/util/fctest_functions.F90 Show resolved Hide resolved
src/tests/util/fctest_functions.F90 Show resolved Hide resolved
src/tests/util/fctest_functions.F90 Outdated Show resolved Hide resolved
Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbrdar for addressing all comments!

@wdeconinck wdeconinck merged commit b3c4918 into develop Nov 28, 2023
89 of 101 checks passed
wdeconinck added a commit that referenced this pull request Dec 11, 2023
* release/0.36.0: (25 commits)
  Update Changelog
  Version 0.36.0
  Add atlas_Redistribution to atlas_module
  Performance improvement in EqualAreaPartitioner for StructuredGrid
  Add EqualAreaPartitioner which is geometry based compared to EqualRegionsPartitioner which is loadbalanced
  Add fallback mechanism to MatchingMeshPartitionerLonLatPolygon
  Fix MatchingMeshPartitionerBruteForce
  Fix MDPI_gulfstream: 180 degrees phase shift corrected
  Feature/fortran api init functions (#165)
  Fix failing tests for IntelLLVM Release builds
  GHA: Install intel-oneapi with mpi-devel for access to MPI headers and Fortran modules
  Fix intel compiler version in github actions, and add IntelLLVM
  Add compile flag -fno-finite-math-only for Intel LLVM compiler (icx, icpx)
  Add Fortran API for functionspace::CellColumns (#164)
  Cleanup
  Fix logic
  Fix interpolation warnings
  Add Fortran interface for Redistribution (#160)
  Add atlas_TriangularMeshBuilder with Fortran interface for serial meshes
  Reduce header dependency on atlas_io to prepare for eckit_codec adaptor library
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants