Enable latitude normalisation in KDTree coordinate transform #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (56 commits) Implement field::for_each capabilities (ecmwf#139) Avoid harmless FE_INVALID with nvhpc build Avoid harmless FE_INVALID with nvhpc build Remove ATLAS_FPE=0 environment variable as not needed anymore now Avoid harmless FE_DIVBYZERO with nvhpc build Optimize modules and dependencies for caching Add HPC build options matrix Workaround compiler bug in nvhpc-22.11-release build Update GHA nvidia-21.9 to nvidia-22.11 Avoid and suppress some compiler warnings with nvhpc Fix bug where DelaunayMeshGenerator with 1 partition was not setting the grid in the mesh (ecmwf#143) Use Eigen 3.4 Disable floating point signals for tests on nvidia Add nvidia compiler specific HPC build config Add function to build mesh from imported connectivity data (ecmwf#135) Disable GHA "linux gnu-12" OpenMP for CXX as "omp.h" header is not found :( Add gnu-12 ci to github actions (github-hosted runners) Add gnu-7 ci to github actions with github-hosted runners (ecmwf#136) Setup horizontal_dimensions() for BlockStructuredColumns fields Add function Field::horizontal_dimension() -> std::vector<idx_t> ...
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #140 +/- ##
===========================================
- Coverage 78.27% 77.66% -0.62%
===========================================
Files 820 810 -10
Lines 59820 51877 -7943
===========================================
- Hits 46827 40290 -6537
+ Misses 12993 11587 -1406
☔ View full report in Codecov by Sentry. |
|
Thanks @wdeconinck ! |
wdeconinck
added a commit
that referenced
this pull request
Jul 10, 2023
* release/0.34.0: (78 commits) Version 0.34.0 Fix global indexing for meshes from structured grids with pole patch Fix cells().global_index() metadata for RegularLonLat grids in StructuredMeshGenerator BuildHalo: mark interior added cells as ghost Add example-plugin in doc Introduce colon-separated environment variable ATLAS_PLUGIN_PATH to simplify plugin detection Interpolate from cubedsphere mesh to structured columns (#146) Fix FieldSet::field(std::string) when field has been renamed (fixes #147) Further separate compilation features Field with functionspace optional Introduce features to disable compilation of structural components Remove interdependencies between structural components CMake cleanup Move files to correct places Introduce atlas::mdspan, contributed from github.com/kokkos/mdspan Disable GHA "nvhpc-22.11" as there are random compilation errors, probably related to insufficient disk or memory space atlas_io: fix test command in standalone build Fix and test some use cases with / without calling atlas::initialise() Access to atlas::Library::dataPath without initialising Enable latitude normalisation in KDTree coordinate transform (#140) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ecmwf/eckit#68
Similar changes could be made in many places where
convertSphericalToCartesianis called, but I wanted to start modest: this is the call that prevents an atlas KDTree from being constructed with an atlas Gaussian grid + structured mesh halo points.