Add ability for users to specify PAPI events in Dr Hook #27
Conversation
This new print clarifies what the next set of prints are referring to. It also slightly optimises the subsequent control flow.
This allows user to specify their own PAPI events (up to MAXNPAPICNTRS, defaulting to 4). This is done with the DR_HOOK_PAPI_COUNTERS flag. If the flag is not specified, and PAPI is enabled, then the following defaults will be chosen: PAPI_TOT_CYC PAPI_FP_OPS PAPI_L1_DCA PAPI_L2_DCM If an invalid event is chosen, then DrHook will simply crash will an appropriate error message.
|
|
|
That looks all like good improvements. Thanks @Andrew-Beggs-ECMWF for doing the review + modifications of #26 . Ultimately you (or someone else?) that looks at benchmarking IFS should be happy with this feature and sign off that everything works as expected. |
This commit removes all tabs, in favour of two spaces, in files touched by ecmwf-ifs#26 and ecmwf-ifs#27.
|
That should be all the tabs banished : ) I found that CMake tests aren't quite powerful enough to do the tests that I was envisioning. So I think you're right that it might just be a case of a "works on my machine" guarantee, which should be fine as I've tested it on our hpc2020 machine. |
|
Just adding a comment that I intend to do some work to this PR to better align it with how extensions are handled in #28. After that I think it should be good to go : ) |
This PR extends #26 by allowing users to specify their own PAPI events (up to MAXNPAPICNTRS, defaulting to 4). This is done with the DR_HOOK_PAPI_COUNTERS flag. If the flag is not specified, and PAPI is enabled, then the following defaults will be chosen:
PAPI_TOT_CYC
PAPI_FP_OPS
PAPI_L1_DCA
PAPI_L2_DCM
If an invalid event is chosen, then DrHook will simply crash will an appropriate error message.
Other commits are also included, which tidy up error messages introduced in #26.
Currently in draft mode to allow for review while adding tests.