Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pragma guard around OpenMP directives to fix a bug with GNU10.1/10.2 #22

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

shlyaeva
Copy link
Contributor

Adds pragmas to turn off an OpenMP-parallelization of one loop that segfaults with GNU10.1/10.2 (and possibly 10.0), see details and discussion in #20.

Fixes #20

@FussyDuck
Copy link

FussyDuck commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@wdeconinck
Copy link
Collaborator

Thanks @shlyaeva all good. Just waiting for your CLA signature.

@shlyaeva
Copy link
Contributor Author

Thank you @wdeconinck! I signed the agreement, maybe it takes some time to show up?

@wdeconinck
Copy link
Collaborator

Thank you @wdeconinck! I signed the agreement, maybe it takes some time to show up?

I think it's possible your user email used to make the commit is not registered in your GitHub profile. When hovering over the "committer" it doesn't allow me to click as it does with other commits.

@shlyaeva
Copy link
Contributor Author

@wdeconinck I corrected the email to the one associated with my profile, and force-pushed that change here, should be all good now.

@wdeconinck wdeconinck changed the base branch from main to develop January 13, 2023 08:00
@wdeconinck wdeconinck merged commit 8f194d0 into ecmwf-ifs:develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfaults in ltinv_ctlad_mod with GCC 10.2 and 10.1 (related to OpenMP)
4 participants