Qualify the module imports of SULEG #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Debug, linux intel : segfault. Well that was unexpected. A debug build with intel/2021.4.0 on the Atos HPC passes all tests. |
|
It seems that "develop" is also failing now. Perhaps something intermittent or new compiler version used by intel oneapi. |
|
Yeah it's very weird. |
|
@wdeconinck The tests are magically passing now. |
|
Yes I tried rerunning yesterday and now all tests passed. It's what I expected as these changes should not have had any negative impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite hard to track down variables like
D,R,F, etc. inSULEG. This PR qualifies all module imports inSULEGso it's clear where external variables came from. I focused onSULEGbecause it has an unusually large number of module imports, but I think we should gradually start doing this elsewhere as well.