Introduce V-W set specification as command line arguments in benchmark #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to see the default values for the various parameters at the top of the program rather than in the command line parsing subroutine.
Why did I remove those...
samhatfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case at TCO7999 where the default behaviour of setting NPRTRV and NPRTRW didn't work. In this case it's useful to override this behaviour and force the parameters yourself, so I've added them as command line arguments. You can provide just one of the two, in which case the existing logic will determine the other by dividing NPROC by the provided value. It will also make sure the product of the two equals NPROC.
I've also included a commit which moves all default option values from
get_command_line_argumentsto the top of the program, for consistency,