Remove default values for TPM_GEN variables #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These gave the impression that TPM_GEN is the appropriate place to change the default values of these variables. This is not the case, because whatever value they take here is overwritten in SETUP_TRANS0. The latter is where default values should be set.
wdeconinck
approved these changes
Oct 4, 2024
wdeconinck
added a commit
that referenced
this pull request
Oct 11, 2024
* release/1.5.0: (86 commits) Version 1.5.0 Workaround for supporting GPU-aware MPI on Cray/AMD platforms Workaround for ASYNC statements in TRMTOL for AMD GPUs Pin buffers in benchmark (#158) Remove default values for TPM_GEN variables (#159) Fix case inconsistencies Add option to not do in-place FFT Search for OpenACC only if explicitly enabled Use Fortran linker for ectrans_test_setup_trans0 Update CMakeLists.txt Fix tabs Fix typo in TRGTOL Update src/trans/gpu/algor/hicfft.hip.cpp Update paths to HIP includes to support ROCm > 6 add gpu graphs define Fixup diagnostic prints missing since #141 add ungrouepd gemms Make default for --niter-warmup 3 if not specified, experimentally a better value Add --niter-warmup command line option to be able to configure warmup iterations Remove spurious print ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These gave the impression that TPM_GEN is the appropriate place to change the default values of these variables. This is not the case, because whatever value they take here is overwritten in SETUP_TRANS0. The latter is where default values should be set.