-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AMD GPUs #157
Conversation
Note that graph support has not been tested on AMD GPUs yet. |
Co-authored-by: Paul Mullowney <[email protected]>
a8592fe
to
f1301b3
Compare
For future reference and my understanding of this bizarre MPI related change. Removing Also there is no checking on arguments because of any missing interface, meaning we can pass whatever and any number of arguments. It so happens (again by luck?) that the signature matches on a byte-level, meaning that I don't consider this as a final solution, but good enough for now, seeing that it works experimentally on some of our tested platforms / compilers / mpi libraries, and seeing that the GPU adaptations are very much in flux. |
Exactly. Also, the implication is that there is something wrong with What would be great would be to confirm @wdeconinck's hypothesis by inspecting the object code generated when you import and don't import |
Co-authored-by: Paul Mullowney <[email protected]> Co-authored-by: Willem Deconinck <[email protected]>
0a5b6df
to
6840754
Compare
Finally, we are able to run the develop branch on AMD GPUs.
Many many thanks to @PaulMullowney for getting this done.
Note that #155 should be merged first.