Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Add missing ASYNC statements #133

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

samhatfield
Copy link
Collaborator

Without these the UPDATE can be carried out before the device arrays have been properly filled by the preceding ASYNC(1) unpacking DO loop.

This was causing an obscure error during integration testing of develop in the IFS.

Without these the UPDATE can be carried out before the device arrays
have been properly filled by the preceding ASYNC(1) unpacking DO loop.
@samhatfield samhatfield added bug Something isn't working priority labels Aug 12, 2024
Copy link
Collaborator

@marsdeno marsdeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

Copy link
Collaborator

@lukasm91 lukasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samhatfield samhatfield merged commit 5f950c9 into develop Aug 12, 2024
21 checks passed
@samhatfield samhatfield deleted the samhatfield/add_missing_asyncs branch August 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants