Remove NCOMBFLEN parameter #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting find. I wonder when it was removed... Similar to a previous cleanup, I would ask to keep the API stable but deprecate the use of kcombflen in setup_trans0 because this parameter is still used in e.g. ifs-source/arpifs/setup/sutrans0.F90 Definitely however we should have another ifs-source commit to fix the use of these deprecated parameters. |
wdeconinck
requested changes
Jul 15, 2024
|
It was removed 16 years ago :p But yes I will keep the argument but issue a warning. Just a second. |
This was effectively deprecated in 8aaf3ec.
samhatfield
force-pushed
the
samhatfield/remove_ncombflen
branch
from
37bbc43
to
ec50339
Compare
|
PR updated. |
|
16!!! years? Good riddance. |
wdeconinck
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't used anywhere.