vscode: support editor/title/run predefined entry #80
Conversation
There was a problem hiding this comment.
Thank you @rschnekenbu! Seems to work great i only have one minor issue.
For me the *.md files seem to have only one (or two with your changes) menu entries, instead of two/four.
Could you double check, if the build extension is up to date with the source, or does the markdown file need to have some other properties?
|
@sgraband, thanks a lot for your review! |
There was a problem hiding this comment.
I am still not able to get 4 menu entries, but maybe something is off on my side. It isn't really relevant for this change anyway, i guess, as the missing menu entry, is simply a duplicate example from the one that is already shown.
So from my side you can go ahead and open the upstream PR. And when it works for the reviewer there, we should not have a problem.
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
What it does
Adds a missing predefined entry in the menus
This enables the possibility to contribute menus to editor/title/run entry as defined in vscode.
Fixes eclipse-theia#9387
Contributed on behalf of ST Microelectronics
How to test
Try to open a menu on any file except md file, one menu should be contributed by the extension. A second one will pop-up on any md file.
Update your
theiarepository to use this PRAny file should now also have an additional run menu entry, and the md files shall display a total of 4 menus with this extension.
Review checklist
Reminder for reviewers