Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove invasive split terminal action #74

Closed
wants to merge 1 commit into from

Conversation

rschnekenbu
Copy link

@rschnekenbu rschnekenbu commented Mar 28, 2023

What it does

Partially removes some intrusive split terminal actions in views

Current situtation:
terminal-split

fix eclipse-theia#12357

Contributed on behalf of STMicroelectronics

How to test

To test in theia:

  • Check that by default, split terminal action does not appear on toolbars for various views.
  • Check that on terminal views, the split terminal icon is still present when the terminal view is active
  • terminal context menu still displays the split terminal entry

Limitations: when a terminal is active, there are still some polluting split terminal entries on some views.

terminal-split-after

Review checklist

Reminder for reviewers

Contributed on behalf of STMicroelectronics
@tsmaeder
Copy link
Collaborator

I'm still seeing the "Split Terminal" action in the view toolbars. It's disabled, but it's there.

@tsmaeder
Copy link
Collaborator

Forget that...after a proper rebuild, it seems to work.

Copy link
Collaborator

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rschnekenbu
Copy link
Author

Thanks for the quick review, @tsmaeder! I will create the PR on eclipse-theia repo.

@rschnekenbu
Copy link
Author

closed in favor of eclipse-theia#12358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove invasive Split Terminal action in the toolbars
2 participants