Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40 Initial Agent View and Communication History #112

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ndoschek
Copy link

@ndoschek ndoschek commented Jul 30, 2024

What it does

GH-40 Initial Agent View and Communication History

  • Add initial ai-history and ai-history-ui extensions
  • Provide CommunicationRecordingService to record agent communication
  • Provide second DummyAgent for demo purposes
  • Showcase recording implementation with both agents
  • Add basic history UI

Co-authored-by: Olaf Lessenich [email protected]

Closes https://github.com/eclipsesource/osweek-2024/issues/40

How to test

Follow-ups

Review checklist

Reminder for reviewers

@sgraband sgraband requested review from rschnekenbu and sgraband July 30, 2024 09:25
Copy link

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Works great! I just have one small comment below.

Comment on lines 1 to 21
// *****************************************************************************
// Copyright (C) 2024 EclipseSource GmbH.
//
// This program and the accompanying materials are made available under the
// terms of the Eclipse Public License v. 2.0 which is available at
// http://www.eclipse.org/legal/epl-2.0.
//
// This Source Code may also be made available under the following Secondary
// Licenses when the conditions for such availability set forth in the Eclipse
// Public License v. 2.0 are satisfied: GNU General Public License, version 2
// with the GNU Classpath Exception which is available at
// https://www.gnu.org/software/classpath/license.html.
//
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
// *****************************************************************************
import { ContainerModule } from '@theia/core/shared/inversify';

export default new ContainerModule(bind => {
// bind(DefaultCommunicationRecordingService).toSelf().inSingletonScope();
// bind(CommunicationRecordingService).toService(DefaultCommunicationRecordingService);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for the review! Oh yes, that was an oversight, will push an update and rebase.

@ndoschek ndoschek force-pushed the feat/ai-chat-on-history branch from 328d26a to 7df16e0 Compare July 30, 2024 10:05
@ndoschek ndoschek requested a review from sgraband July 30, 2024 10:06
Copy link

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@ndoschek ndoschek merged commit a590eee into feat/ai-chat Jul 30, 2024
1 check passed
@sdirix sdirix deleted the feat/ai-chat-on-history branch August 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants