Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2147] update to asm 9.5 #2171

Merged
merged 1 commit into from
Apr 6, 2023
Merged

[#2147] update to asm 9.5 #2171

merged 1 commit into from
Apr 6, 2023

Conversation

cdietrich
Copy link
Member

@cdietrich cdietrich commented Apr 3, 2023

[#2147] update to asm 9.5

@cdietrich
Copy link
Member Author

cdietrich commented Apr 3, 2023

@szarnekow @LorenzoBettini any idea what could be the problem here:
https://ci.eclipse.org/xtext/job/xtext/job/cd_asm950/4/
the asm it complains to missing seems at least to be in the antDeps dir

how can i run this test easy locally from maven?
how do i need to run the full build and then the build in ide.tests to call this test
what do i need to deploy stuff to a local maven repo and then consume it from there?

@cdietrich
Copy link
Member Author

cdietrich commented Apr 3, 2023

i see. filename has changed

<include name="org.objectweb.asm*.jar" />

@LorenzoBettini
Copy link
Contributor

@szarnekow @LorenzoBettini any idea what could be the problem here: https://ci.eclipse.org/xtext/job/xtext/job/cd_asm950/4/ the asm it complains to missing seems at least to be in the antDeps dir

how can i run this test easy locally from maven? how do i need to run the full build and then the build in ide.tests to call this test what do i need to deploy stuff to a local maven repo and then consume it from there?

Sorry, I'm late, but I see you figured it out.
I thought I had left comments on that project documenting how to prepare for running tests from eclipse.

@cdietrich
Copy link
Member Author

@LorenzoBettini i was asking for running a single test for maven.
i still have the problen that the branches maven artifacts now sit in my local maven repo
this is why i am asking

@LorenzoBettini
Copy link
Contributor

@LorenzoBettini i was asking for running a single test for maven. i still have the problen that the branches maven artifacts now sit in my local maven repo this is why i am asking

To run a very single test you can use -Dtest="TestClassName".
To run tests in a single project, I usually first install everything (without tests) and then run the build on a single project.

@cdietrich cdietrich force-pushed the cd_asm950 branch 2 times, most recently from c739464 to e06e23c Compare April 5, 2023 15:57
@@ -18,6 +18,10 @@
<unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0"/>
<repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/nightly"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh.

@cdietrich cdietrich changed the title [WIP][#2147] update to asm 9.5 [#2147] update to asm 9.5 Apr 6, 2023
@cdietrich cdietrich force-pushed the cd_asm950 branch 2 times, most recently from 8b538ca to 7be14cb Compare April 6, 2023 07:48
NOTICE.md Outdated
@@ -86,15 +86,15 @@ Google Guice / Inject Core API (5.0.1)

* License: Apache License, 2.0

Gradle Wrapper (7.4)
Gradle Wrapper (8.x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still being used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we store it in our resources of the wizard bundle and create it when we generate a project based on Gradle, is that right @cdietrich ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is why this is there in the first place

Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich cdietrich merged commit 4989124 into main Apr 6, 2023
@cdietrich cdietrich deleted the cd_asm950 branch April 6, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants