Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Move to Maven/Tycho for projects and build infrastructure #350

Closed
LorenzoBettini opened this issue Jan 30, 2023 · 12 comments
Closed

Move to Maven/Tycho for projects and build infrastructure #350

LorenzoBettini opened this issue Jan 30, 2023 · 12 comments
Labels
Milestone

Comments

@LorenzoBettini
Copy link
Contributor

See also eclipse/xtext-lib#499 and eclipse/xtext-core#2052 eclipse/xtext-extras#858 eclipse/xtext-xtend#1445 eclipse/xtext-eclipse#1992

@LorenzoBettini
Copy link
Contributor Author

@cdietrich would it be OK if I move all the projects of releng as top-level projects? Or do you think that before repo merging it's better to leave them where they are?

@cdietrich
Copy link
Member

cdietrich commented Jan 30, 2023

i dont care for now. but i guess merging wll be easier if same structure

@LorenzoBettini
Copy link
Contributor Author

@cdietrich for the moment I won't touch them.

@merks , as usual, could you please check that this p2 repository is ok?

https://ci.eclipse.org/xtext/job/xtext-umbrella/job/lb_2052_maven_tycho/lastSuccessfulBuild/artifact/build/p2-repository/

This should be the aggregated Xtext repository with signed contents (the signed bundles are taken from the previously built p2 repositories in Jenkins jobs of the single Git repositories). However, the signing of the features takes place in the Jenkins job of this Git repository.

@cdietrich there are a few sources missing because I had changed the feature layout in some features like .xbase.lib; if you remember, I said that in general a feature should not contain sources of bundles. We can then later decide about that: revert the old behavior or update all features accordingly (but then also publish source features in the p2 repository)

@LorenzoBettini
Copy link
Contributor Author

@merks you mentioned that you use a Jenkins job that we can copy in our JIRO, https://ci.eclipse.org/oomph/job/repository-analyzer-extra/

if we do that, I guess we should change the output dir of the report, or can we still generate the result in the same area where you generate your reports?

@merks
Copy link

merks commented Feb 2, 2023

@LorenzoBettini

I've regenerated the report:

https://download.eclipse.org/oomph/archive/reports-extra/xtext-tycho/ci.eclipse.org/xtext/job/xtext-core/job/lb_2052_maven_tycho/lastSuccessfulBuild/artifact/build/p2-repository/index.html

Yes, if you copy the job you will have to change the where things are published. I changed it a bit to make it easier to copy and paste it. This section needs to change:

# Project-specific locations.
# Remember use to "archive" in the name of the output so that the reports are not mirrored.
#
LOGIN="[email protected]"
OUT_DIR="/home/data/httpd/download.eclipse.org/oomph/archive"
OUTPUT="reports-extra/${NAME}"

The URL and NAME parameters on the job you may wish to hard-code...

@LorenzoBettini
Copy link
Contributor Author

@merks thanks, I'll try that.

But in the meantime, could you please check this repo

https://ci.eclipse.org/xtext/job/xtext-umbrella/job/lb_2052_maven_tycho/lastSuccessfulBuild/artifact/build/p2-repository/

the one I mentioned in my comment #350 (comment)

this is different from the one you checked now: this one should represent the complete aggregated p2 repository (note it's xtext-umbrella, not xtext-core).

Thanks in advance

@LorenzoBettini
Copy link
Contributor Author

@merks Thanks!
Just to be sure: the report says everything is OK, doesn't it? I mean from the signing point of view (which is what @cdietrich wants to be sure of).

@merks
Copy link

merks commented Feb 2, 2023

Yes, if something were not signed it would show up in the signing certificate sections. Note too that the job status shows if there are serious problems:

https://ci.eclipse.org/oomph/job/repository-analyzer-extra/

There are actual test results:

https://ci.eclipse.org/oomph/job/repository-analyzer-extra/124/testReport/

@LorenzoBettini
Copy link
Contributor Author

Yes, if something were not signed it would show up in the signing certificate sections. Note too that the job status shows if there are serious problems:

https://ci.eclipse.org/oomph/job/repository-analyzer-extra/

There are actual test results:

https://ci.eclipse.org/oomph/job/repository-analyzer-extra/124/testReport/

Thank you so much for the great tools and support! :)

@LorenzoBettini
Copy link
Contributor Author

i dont care for now. but i guess merging wll be easier if same structure

OK, so I'll move all the projects at the root level

@cdietrich cdietrich added this to the Release_2.31 milestone Apr 3, 2023
@cdietrich
Copy link
Member

with repo merge this is done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants