Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[eclipse/xtext#2134] remove dependency to obsolte jdt.compiler.(tool|apt) #2053

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

cdietrich
Copy link
Member

[eclipse/xtext#2134] remove dependency to obsolte jdt.compiler.(tool|apt)

@cdietrich cdietrich added this to the Release_2.30 milestone Jan 14, 2023
@cdietrich
Copy link
Member Author

@LorenzoBettini can i merge this now to have a green build again?

@LorenzoBettini
Copy link
Contributor

@cdietrich I still haven't got time to test it personally, but I think we can merge it. The fragments were needed because there were no other ways to force them in the TP (when jdt.core was also present). Now that the fragments are gone, we should be safe without them (as long as they are also removed from the dependencies of the maven plugin xtext-maven-plugin).

@cdietrich
Copy link
Member Author

@LorenzoBettini the point is that they are not, cause we are still on old platform from a maven perspective
thus i wanted you to have a look

@LorenzoBettini
Copy link
Contributor

@cdietrich OK, I see. Then I'll try to do that ASAP. I'm actively working on #2052 for the moment.

I guess it won't be a problem anyway, because we won't have a mixture of apt and tool from the TP, because from the TP point of view those fragments are not there anymore.

I guess that, from the xtext-maven-plugin point of view:

  • if jdt.core is taken from the more recent TP and apt from the old Maven dep, apt will not simply be used
  • if jdt.core is taken from the old Maven dep it will also find the old apt, so it should be fine

@cdietrich
Copy link
Member Author

gonna merge for now, if more adjustment needed we need a second pr anyway

@cdietrich cdietrich merged commit 09d7556 into master Jan 17, 2023
@cdietrich cdietrich deleted the cd_xtext_issue2134 branch January 17, 2023 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants