Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[LSP] Problems for a deleted file are shown after deletion #716

Closed
RealTYPICAL opened this issue Apr 25, 2018 · 8 comments
Closed

[LSP] Problems for a deleted file are shown after deletion #716

RealTYPICAL opened this issue Apr 25, 2018 · 8 comments
Assignees
@cdietrich
Labels
bug confirmed
Milestone
Release_2.14

Comments

@RealTYPICAL
Copy link
Contributor

Steps to reproduce:

  1. Create a file with some errors in it.
  2. Delete the file.
  3. Check the errors produced.

Behaviour:

The errors for that file still exist even though the file doesn't.

Expected:

The errors for that file should be cleared.

https://github.com/RealTYPICAL/MyDSL_Imports

A small DSL example exists here but the behaviour should still work on any language.

If you need anymore feedback then please let me know.
@cdietrich
Copy link
Member

what do you exactly mean by "The errors for that file still exist"

@RealTYPICAL
Copy link
Contributor Author

After deleting the file, the server still gives errors as if the file still exists/hadn't been deleted.

@cdietrich
Copy link
Member

which client do you use?

i am not sure how the protocol is for this usecase.
at least in my debugging i did not see any new messages regarding issues sent after deletion so i am not sure what should happen in this case

@RealTYPICAL
Copy link
Contributor Author

VSCode

@cdietrich
Copy link
Member

created microsoft/language-server-protocol#463

cdietrich added a commit that referenced this issue Apr 25, 2018
@cdietrich
[#716] [LSP] Problems for a deleted file are shown after deletion
28e6da0 
Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich cdietrich mentioned this issue Apr 25, 2018
Merged
@cdietrich cdietrich self-assigned this Apr 25, 2018
@cdietrich cdietrich added this to the Release_2.14 milestone Apr 25, 2018
@cdietrich
Copy link
Member

prepared a pr but still wont to wait until the protocol issue is cleared

cdietrich added a commit that referenced this issue Apr 25, 2018
@cdietrich
[#716] [LSP] Problems for a deleted file are shown after deletion
be7a958 
Signed-off-by: Christian Dietrich <[email protected]>
cdietrich added a commit to eclipse/xtext-xtend that referenced this issue Apr 25, 2018
@cdietrich
[eclipse/xtext-core#716] Fixed tests after changes in xtext-core
ed06712 
Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich cdietrich mentioned this issue Apr 25, 2018
Merged
cdietrich added a commit that referenced this issue Apr 26, 2018
@cdietrich
Merge pull request #718 from eclipse/cd_issue716
3dbf100 
[#716] [LSP] Problems for a deleted file are shown after deletion
cdietrich added a commit to eclipse/xtext-xtend that referenced this issue Apr 26, 2018
@cdietrich
Merge pull request #437 from eclipse/cd_core_issue716
4b96797 
[eclipse/xtext-core#716] Fixed tests after changes in xtext-core
@cdietrich
Copy link
Member

Fixed in 2.14.0

@RealTYPICAL could you test with the latest snapshot from
http://services.typefox.io/open-source/jenkins/job/xtext-core/job/master/lastSuccessfulBuild/artifact/build/maven-repository/

@RealTYPICAL
Copy link
Contributor Author

Works on my side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cdietrich cdietrich

Labels
bug confirmed
Projects
None yet
Milestone
Release_2.14
Development

No branches or pull requests
2 participants
@cdietrich @RealTYPICAL