paho Client.ClientConfig is now private
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users could previously access/change the ClientConfig held by `paho.Client`; this invited race conditions (`paho.Client` could use values from the config at any time and no locking mechanism was provided). To avoid this, the config is now private and examples etc have been updated. A getter for `ClientID` has been added (as this was needed in examples); I suspect additional getters may be of benefit (but will await feedback for that). This may break some users code (but that is probably a good thing) (cherry picked from commit 1b2c146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users could previously access/change the ClientConfig held by
paho.Client; this invited race conditions (paho.Clientcould use values from the config at any time and no locking mechanism was provided).To avoid this, the config is now private and examples etc have been updated. A getter for
ClientIDhas been added (as this was needed in examples); I suspect additional getters may be of benefit (but will await feedback for that).This may break some users code (but that is probably a good thing)
closes #210