Autopaho: Call error call back a maximum of once per connection #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in relation to one event. This mirrored the paho functionality but does not make much sense from an end user perspective, so this change prevents multiple calls to `OnClientError` in relation to a single connection. We also prevent errors from being logger when the user has called `Disconnect` (it's not an error if it's the result of a request).
MattBrittan
changed the title
Open
thejan2009
approved these changes
Aug 9, 2023
autopaho/error.go
Outdated
| } else { | ||
| e.debug.Printf("received extra error: %s", err) | ||
| return false |
There was a problem hiding this comment.
Nitpick, we can now avoid else clause because of return statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoPaho had the potential to call the error call beck multiple times in relation to one event.
This mirrored the
pahofunctionality but does not make much sense from an end user perspective,so this change prevents multiple calls to
OnClientErrorin relation to a single connection.We also prevent errors from being logger when the user has called
Disconnect(it's not an errorif it's the result of a request) and add a test.
closes #157