handling 0 Packet Identifier in MIDs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance that you could add a test? (I provided a very rough one in the issue). I believe that MIDs is going to change further (see existing issues etc) so having a test for this situation would be beneficial in preventing the reintroduction of this problem. |
tomatod
force-pushed
the
handle-zero-packetidentifier
branch
from
d3698b1
to
346800c
Compare
tomatod
force-pushed
the
handle-zero-packetidentifier
branch
from
346800c
to
22afd86
Compare
|
@MattBrittan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #145 .
To avoid panic, handling 0 Packet Identifier although it is invalid (valid range is 1 - 65535).