Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver dependency to the ovsx package #733

Merged
merged 1 commit into from
May 2, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented May 2, 2023

When trying to publish a package to open-vsx after installing ovsx via the command npm i -g @vscode/vsce ovsx, the package cannot seem to find the semver dependency. It's a transitive dependency from @vscode/vsce but explicitly used in the ovsx code.

This led to a failure in our deployment pipeline, see here.

This PR adds the semver package explicitly, so that this issue doesn't occur anymore.

Copy link
Member

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spoenemann spoenemann merged commit 5df9b74 into eclipse:master May 2, 2023
@msujew msujew deleted the msujew/explicit-semver branch May 2, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants