Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "unique_extension_public_id" unique constraint violation #819

Closed
amvanbaren opened this issue Oct 19, 2023 · 16 comments · Fixed by #822
Closed

Fix "unique_extension_public_id" unique constraint violation #819

amvanbaren opened this issue Oct 19, 2023 · 16 comments · Fixed by #822
Assignees

Comments

@amvanbaren
Copy link
Contributor

No description provided.

@amvanbaren amvanbaren self-assigned this Oct 19, 2023
@kineticsquid
Copy link
Contributor

While debugging EclipseFdn/open-vsx.org#1444, I attempted to publish vscjava.vscode-gradle, with the following result:

MBP temp % npx ovsx publish vscjava.vscode-gradle-3.12.7.vsix -p **************** --debug
Error: Internal Server Error
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/ovsx/lib/registry.js:176:40)
    at IncomingMessage.emit (node:events:538:35)
    at endReadableNT (node:internal/streams/readable:1345:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
johnkellerman@Johns-MBP temp % 

The logs showed a unique_extension_public_id unique constraint violation.

@brc-dd
Copy link

brc-dd commented Oct 23, 2023

Hi, I'm also getting similar error while publishing Vue.vscode-typescript-vue-plugin -- https://github.com/vuejs/language-tools/actions/runs/6613922320/job/17962756990

Looks like it's also being published from https://github.com/open-vsx/publish-extensions/blob/87c52764cb53a8eed3cb09d940e1907a18670374/extensions.json#L1411-L1419

Though I'm not sure if removing that entry from publish-extensions will work 👀

@amvanbaren
Copy link
Contributor Author

Though I'm not sure if removing that entry from publish-extensions will work 👀

@filiptronicek Do you know if that will work?

filiptronicek added a commit to EclipseFdn/publish-extensions that referenced this issue Oct 23, 2023
@filiptronicek
Copy link
Member

Do you know if that will work?

@amvanbaren don't know, let's try it :)

Made the change in EclipseFdn/publish-extensions@b0c4b9e, but I guess this alone won't fix this. We can try unpublishing the latest version and let @brc-dd publish again 🙏.

@kineticsquid could you help with removing the failing version, 1.8.20?

@kineticsquid
Copy link
Contributor

@filiptronicek Version 1.8.20 of which extension? This is what I see for vscode-typescript-vue-plugin:

image

@brc-dd
Copy link

brc-dd commented Oct 24, 2023

Hi, so the extension ID on vscode is Vue.vscode-typescript-vue-plugin. It was there in that publish-extensions file. But I don't think it ever got published (IIRC it just used to throw namespace already exists or something like that in publish-extensions' actions).

(That johnsoncodehk.vscode-typescript-vue-plugin is the older name of the extension, but it was renamed to Vue.vscode-typescript-vue-plugin in vscode.)

@kineticsquid
Copy link
Contributor

Right, so I think the root cause is the renaming of the extension, which then caused the unique constraint violation. @amvanbaren @filiptronicek I think we've seen this before, haven't we?

@filiptronicek are you seeing 1.8.20 on open-vsx.org?

@filiptronicek
Copy link
Member

@kineticsquid I am

image

@brc-dd
Copy link

brc-dd commented Oct 25, 2023

@filiptronicek I think you're looking at https://open-vsx.org/extension/Vue/volar not https://open-vsx.org/extension/Vue/vscode-typescript-vue-plugin 👀 (or is it something that only shows to the team?)

@kineticsquid
Copy link
Contributor

@brc-dd That was my conclusion as well.

@amvanbaren If we remove vscode-typescript-vue-plugin from auto-publishing and then I completely remove the extension (un-install all 13 versions), does that eliminate the potential conflicting id? IOW, at that point will we be able to publish to Vue namespace?

@filiptronicek
Copy link
Member

Sorry, must've been! Doesn't show up for me at all
image

@amvanbaren
Copy link
Contributor Author

@kineticsquid I have a fix ready for this issue. There's no need to do this manually anymore.
Can you create a new issue for @brc-dd in the EclipseFdn/open-vsx.org repo?

@kineticsquid
Copy link
Contributor

@amvanbaren Not sure I'm following. With your fix, what do we need in the open-vsx.org issue for @brc-dd?

@amvanbaren
Copy link
Contributor Author

@kineticsquid Because this issue is about to be closed. So I would recommend to open an issue in EclipseFdn/open-vsx.org to keep track of @brc-dd's specific (operational) issue.

@kineticsquid
Copy link
Contributor

@brc-dd Would open an issue as @amvanbaren specified for your remaining work?

@brc-dd
Copy link

brc-dd commented Oct 31, 2023

Hi, I'll try releasing a version locally. If it fails, will create a issue there with debug information 👍 (CI run doesn't give much info about what's going wrong.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants