Skip to content

Commit

Permalink
On branch edburns-msft-em-5989-review-2-0 (#232)
Browse files Browse the repository at this point in the history
modified:   spec/src/main/asciidoc/metrics.adoc

Two trivial changes.

- Clarify that conditions are per-attribute. Might not be obvious to someone not deeply familiar with SemConv.

- SemConv uses `Opt-In`. I corrected the case.

Signed-off-by: Ed Burns <[email protected]>
  • Loading branch information
edburns authored Sep 9, 2024
1 parent e1975f4 commit fca8b82
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions spec/src/main/asciidoc/metrics.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ The following metrics MUST be provided by runtimes. These are as defined in the

All attributes that are listed as required and stable in the OpenTelemetry Semantic Conventions MUST be included.

All attributes that are listed as conditionally required and stable in the OpenTelemetry Semantic Conventions MUST be included when the condition described in the OpenTelemetry Semantic Conventions is satisfied.
All attributes that are listed as conditionally required and stable in the OpenTelemetry Semantic Conventions MUST be included when the per-attribute condition described in the OpenTelemetry Semantic Conventions is satisfied.

All attributes that are listed as recommended and stable in the OpenTelemetry Semantic Conventions SHOULD be included if they are readily available and can be efficiently populated.

All attributes that are listed as opt-in and stable in the OpenTelemetry Semantic Conventions MUST NOT be included unless the implementation provides a means for users to configure which opt-in attributes to enable. This requirement is based on OpenTelemetry Semantic Conventions documentation indicating that opt-in attributes MUST NOT be included unless the user has a way to choose if they are enabled/disabled.
All attributes that are listed as Opt-In and stable in the OpenTelemetry Semantic Conventions MUST NOT be included unless the implementation provides a means for users to configure which Opt-In attributes to enable. This requirement is based on OpenTelemetry Semantic Conventions documentation indicating that Opt-In attributes MUST NOT be included unless the user has a way to choose if they are enabled/disabled.

Attribute values and usage guidelines as defined in the semantic conventions document MUST be followed.

Expand Down Expand Up @@ -111,7 +111,7 @@ recommended

* `network.protocol.version`

opt-in
Opt-In

* `server.address`
* `server.port`
Expand Down

0 comments on commit fca8b82

Please sign in to comment.