-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the ScheduledExecutorService to be provided by the container #178
Conversation
@eclipse-microprofile-bot test this please |
Can one of the admins verify this patch? |
@Resource | ||
private ScheduledExecutorService executorService; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This depends on Jakarta concurrency which is not part of MicroProfile. I'm not sure we want to require that for this TCK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that is a fair point ... I'll remove the change to this file but keep the change in the super-class which allows us to override if required.
Signed-off-by: Tom Evans <[email protected]>
953cf41
to
02df0c1
Compare
@eclipse-microprofile-bot test this please |
@eclipse-microprofile-bot test this please (the bot only listens to committers to prevent someone creating a malicious PR which attacks the build system when a build is run) |
@Azquelt any idea why that build failed? |
IIRC this is an issue with old versions of |
On further investigation, it looks like we updated the versions of Maven and Java in the build in order to allow the update of the parent pom in #177. If we get that merged, I expect this PR will then build correctly. |
When running in an Jakarta EE web/full profile environment, the ScheduleExecutorService should be provided by the container.