Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ScheduledExecutorService to be provided by the container #178

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

tevans78
Copy link
Contributor

@tevans78 tevans78 commented Aug 15, 2023

When running in an Jakarta EE web/full profile environment, the ScheduleExecutorService should be provided by the container.

@tevans78
Copy link
Contributor Author

@eclipse-microprofile-bot test this please

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

Comment on lines 39 to 41
@Resource
private ScheduledExecutorService executorService;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on Jakarta concurrency which is not part of MicroProfile. I'm not sure we want to require that for this TCK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that is a fair point ... I'll remove the change to this file but keep the change in the super-class which allows us to override if required.

@tevans78
Copy link
Contributor Author

@eclipse-microprofile-bot test this please

@Azquelt
Copy link
Member

Azquelt commented Aug 16, 2023

@eclipse-microprofile-bot test this please (the bot only listens to committers to prevent someone creating a malicious PR which attacks the build system when a build is run)

@tevans78
Copy link
Contributor Author

tevans78 commented Sep 4, 2023

@Azquelt any idea why that build failed?

@Azquelt
Copy link
Member

Azquelt commented Sep 4, 2023

[ERROR] Failed to execute goal net.revelc.code:impsort-maven-plugin:1.4.1:sort (sort-imports) on project microprofile-reactive-streams-operators-api: Execution sort-imports of goal net.revelc.code:impsort-maven-plugin:1.4.1:sort failed: A required class was missing while executing net.revelc.code:impsort-maven-plugin:1.4.1:sort: null

IIRC this is an issue with old versions of impsort-maven-plugin and newer versions of maven and we maybe need to update to a newer version of the MP Parent POM. I'll have a look tomorrow and see if I can sort it out.

@Azquelt
Copy link
Member

Azquelt commented Sep 6, 2023

On further investigation, it looks like we updated the versions of Maven and Java in the build in order to allow the update of the parent pom in #177.

If we get that merged, I expect this PR will then build correctly.

@Emily-Jiang Emily-Jiang merged commit faa3daf into eclipse:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants