add TCK tests for configuring @Timeout attributes #555
Conversation
|
Contributes to #407. |
tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/config/TimeoutConfigBean.java
Outdated
Show resolved
Hide resolved
Ladicek
force-pushed
the
timeout-config-test
branch
from
d9bf513 to
72fc486
Compare
| */ | ||
| @ApplicationScoped | ||
| public class TimeoutConfigBean { | ||
| @Timeout(value = 1, unit = ChronoUnit.MILLIS) |
There was a problem hiding this comment.
Since @Timeout has a lot of advantages when used together with @Asynchronous, I am wondering add @Asynchronous on one of the endpoint might be good. Thoughts?
There was a problem hiding this comment.
We're only testing timeout config here. Do you think we need a specific test for config when @Timeout and @Asynchronous are used together?
In general I prefer tests to remain focused. This class just tests Timeout + config while we have other tests for Timeout + async.
There was a problem hiding this comment.
Do we have Timeout + async + config? The reason is that timeout is better off to be used with @Asynchronous. We need to ensure the config works. I will be ok to skip Timeout with config and vote for Timeout+Asynchronous with config.
There was a problem hiding this comment.
timeout is better off to be used with @asynchronous
Why is that?
We need to ensure the config works
We do. This PR does that. @Asynchronous makes no difference whatsoever.
There was a problem hiding this comment.
(Actually it might make a difference, depending on implementation, but so can putting the annotation on a class, or configuring an annotation parameter for all methods in a class, or configuring an annotation parameter globally. We decided to stick to this form of testing and I don't quite see how @Asynchronous is so very relevant.)
There was a problem hiding this comment.
In any case, I have just changed one test from synchronous to @Asynchronous.
Signed-off-by: Ladislav Thon <[email protected]>
Ladicek
force-pushed
the
timeout-config-test
branch
from
72fc486 to
70aa2fd
Compare
Signed-off-by: Ladislav Thon [email protected]