-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update osgi.annotation dependency to 8.1.0 #732
Conversation
Version 8.1.0 removes the use of enum types in the annotations which avoids compiler warnings for downstream users of the api jar. We also include osgi.annotation in the tck project to make the annotation classes available to javadoc to avoid warnings. Signed-off-by: BJ Hargrave <[email protected]>
@Emily-Jiang This addresses the compiler warning issue in #716. |
Great. Thank you! |
I believe this should be backported to 2.x. |
I can make a PR for that. What branch? |
We don't have one. Let me create one. Thanks! |
This should cover it: https://github.com/eclipse/microprofile-config/tree/2.x |
Thank you @bjhargrave ! |
@radcortez we can do a service release once @bjhargrave makes a PR against 2.x. |
Unfortunately that fix was merged into Looking in the history I've notice some confusing versioning:
@radcortez, @bjhargrave and @Emily-Jiang I believe this should be backported to @turing85 It seems to me that the problem you posted on Quarkus Zulip is due to the upgrade of MP Config from |
We need to do a release to fix other stuff, so we might as well just release it as is and let consumers update to the new version. |
Version 8.1.0 removes the use of enum types in the annotations which
avoids compiler warnings for downstream users of the api jar.
We also include osgi.annotation in the tck project to make the
annotation classes available to javadoc to avoid warnings.