Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common groupId for all specs and tcks #64

Closed
struberg opened this issue Feb 22, 2017 · 3 comments
Closed

common groupId for all specs and tcks #64

struberg opened this issue Feb 22, 2017 · 3 comments

Comments

@struberg
Copy link
Contributor

Currently we have a groupId of org.eclipse.microprofile.config.specs but it should imo be org.eclipse.microprofile.specs instead.
Same for tcks.

The reason is that people will just have a single folder in maven.central where they can find all microprofile specs.

struberg added a commit to struberg/microprofile-config that referenced this issue Feb 22, 2017
@keilw
Copy link
Contributor

keilw commented Feb 23, 2017

I would not do that as modules should be self-contained. Whether you use a pure Microprofile or SCS (Self-Contained Systems) pattern or a mix of both, "self-contained" also means each module should be independent where possible, so updating config does not force others to be chaged. If the groupId was org.eclipse.microprofile.config.api or org.eclipse.microprofile.config.specs IMO is up to each module, but a general purpose module like org.eclipse.microprofile.core (or "specs") should only be for reusable aspects that are component-neutral, e.g. an independent annotation (though I would rather call that org.eclipse.microprofile.annotation or org.eclipse.microprofile.annotations than just "specs")

@keilw
Copy link
Contributor

keilw commented Feb 23, 2017

IC what you mean with the "specs" artifactId.
https://github.com/eclipse/microprofile-config/blob/master/spec/pom.xml has no binary deliverables, so it cannot be seen as a module of its own. Should all "document/spec" modules be preferred in one artifactId, for that it seems OK. For a TCK testing Config or other modules, I would certainly not mix them, but stick to org.eclipse.microprofile.config.tck or just org.eclipse.microprofile.config (and keep all artifacts under the module groupId)

@struberg
Copy link
Contributor Author

moving them to the following groupId. Please speak out if you find a better name.

org.eclipse.microprofile.apis

OndroMih pushed a commit to OndroMih/microprofile-config that referenced this issue Mar 14, 2017
This makes it easier for users to find all the specs

Signed-off-by: Mark Struberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants