Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigProvider is a bit crowded #62

Closed
struberg opened this issue Feb 22, 2017 · 5 comments
Closed

ConfigProvider is a bit crowded #62

struberg opened this issue Feb 22, 2017 · 5 comments
Milestone

Comments

@struberg
Copy link
Contributor

We should probably move a few bits from the ConfigProvider out of the eyes of the casual user.
We could e.g. move the following methods to ConfigProviderResolver:

  • registerConfig
  • releaseConfig
  • ConfigBuilder inner interface
@struberg
Copy link
Contributor Author

struberg commented Mar 3, 2017

Any comments about this idea?

@gunnarmorling
Copy link
Contributor

I looked at the PR, but I couldn't fully figure how you envision all the pieces to be used. Maybe you could sketch some code using them to clarify the picture?

@struberg
Copy link
Contributor Author

struberg commented Mar 3, 2017

You mean the features itself or just the refactoring?

I just moved the methods from ConfigProvider to ConfigProviderResolver.
So the usage would be ConfigProviderResolver.getInstance().setConfig() etc.

@gunnarmorling
Copy link
Contributor

The purpose of ConfigProviderResolver isn't quite clear to me.

Its comment says "Service provider for ConfigProviderResolver". Should it be "Service provider for ConfigProvider"?

@struberg
Copy link
Contributor Author

@gunnarmorling ConfigProviderResolver was initially a small internal interface delegating 1:1 to the internal implementation. Please feel free to suggest a better name for that class in a separate ticket.

@struberg struberg modified the milestone: config-1.0 Mar 10, 2017
OndroMih pushed a commit to OndroMih/microprofile-config that referenced this issue Mar 14, 2017
A power-user can use the ConfigProviderResolver directly to access the ConfigBuilder.
That way the casual user doesn't get hit with all the complexity he doesn't need most times.

Signed-off-by: Mark Struberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants