-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigProvider is a bit crowded #62
Comments
Any comments about this idea? |
I looked at the PR, but I couldn't fully figure how you envision all the pieces to be used. Maybe you could sketch some code using them to clarify the picture? |
You mean the features itself or just the refactoring? I just moved the methods from ConfigProvider to ConfigProviderResolver. |
The purpose of Its comment says "Service provider for ConfigProviderResolver". Should it be "Service provider for ConfigProvider"? |
@gunnarmorling ConfigProviderResolver was initially a small internal interface delegating 1:1 to the internal implementation. Please feel free to suggest a better name for that class in a separate ticket. |
A power-user can use the ConfigProviderResolver directly to access the ConfigBuilder. That way the casual user doesn't get hit with all the complexity he doesn't need most times. Signed-off-by: Mark Struberg <[email protected]>
We should probably move a few bits from the ConfigProvider out of the eyes of the casual user.
We could e.g. move the following methods to ConfigProviderResolver:
The text was updated successfully, but these errors were encountered: