Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to differentiate null property value and the non-existing value? #56

Closed
Emily-Jiang opened this issue Feb 15, 2017 · 1 comment
Closed

Do we need to differentiate null property value and the non-existing value? #56

Emily-Jiang opened this issue Feb 15, 2017 · 1 comment
Milestone
MP Config 1.0

Comments

@Emily-Jiang
Copy link
Member

In the Config.getValue(), do we need to differentiate the null property value from the non-existing value? The return type of Optional will not be able to differentiate the two situations. Is there any real need to differentiate this?
@struberg
Copy link
Contributor

struberg commented Mar 3, 2017

I thought about that and think we should treat an empty string as not-existing config value.

@struberg struberg modified the milestone: config-1.0 Mar 10, 2017
struberg added a commit to struberg/microprofile-config that referenced this issue Mar 10, 2017
@struberg
refs: eclipse#56 treating empty as not existing.fix broken TCK tests
8ac2220 
Signed-off-by: Mark Struberg <[email protected]>
OndroMih pushed a commit to OndroMih/microprofile-config that referenced this issue Mar 14, 2017
@struberg @OndroMih
fixes eclipse#56 adding JavaDoc and TCK
ad8e2e7 
Empty internal values are to be interpreted as not-existing configuration
Signed-off-by: Mark Struberg <[email protected]>
@dmlloyd dmlloyd modified the milestones: config-1.0, MP Config 1.0 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MP Config 1.0
Development

No branches or pull requests
3 participants
@struberg @dmlloyd @Emily-Jiang