Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ConfigAccessor and ConfigSnapshot from ConfigJSR #384

Closed
struberg opened this issue Sep 4, 2018 · 1 comment
Closed

Backport ConfigAccessor and ConfigSnapshot from ConfigJSR #384

struberg opened this issue Sep 4, 2018 · 1 comment

Comments

@struberg
Copy link
Contributor

struberg commented Sep 4, 2018

ConfigJSR introduce a few advanced features for handling dynamic values.
See the discussions over here
eclipse/ConfigJSR#9
and
eclipse/ConfigJSR#8

struberg added a commit to struberg/microprofile-config that referenced this issue Sep 4, 2018
…onfigJSR

All changes originally by me, except 1 smallish fixes by Tomas Langer.
struberg added a commit to struberg/microprofile-config that referenced this issue Oct 4, 2018
This also includes a fix to avoid OS specific hacks
(envconfig.* properties)
Emily-Jiang added a commit that referenced this issue Dec 9, 2018
Emily-Jiang added a commit that referenced this issue Dec 17, 2018
Emily-Jiang added a commit that referenced this issue Dec 17, 2018
jmesnil added a commit to jmesnil/microprofile-config that referenced this issue Jan 18, 2019
Update the onAttributeChange method to return a ChangeSupport class that
can be used to handle release of resources (in the close method).

When a Config is released, it should call ChangeSupport.close to ensure
that the ConfigSource has a chance to properly release any resources
held by the callbacks.

* Add TCK test ConfigAccessorTest#testOnAttributeChange

Signed-off-by: Jeff Mesnil <[email protected]>
Emily-Jiang added a commit that referenced this issue Jan 23, 2019
Signed-off-by: Emily Jiang <[email protected]>
Emily-Jiang added a commit that referenced this issue Jan 23, 2019
Signed-off-by: Emily Jiang <[email protected]>
jmesnil added a commit to jmesnil/microprofile-config that referenced this issue Feb 8, 2019
Update the onAttributeChange method to return a ChangeSupport class that
can be used to handle release of resources (in the close method).

When a Config is released, it should call ChangeSupport.close to ensure
that the ConfigSource has a chance to properly release any resources
held by the callbacks.

* Add TCK test ConfigAccessorTest#testOnAttributeChange

Signed-off-by: Jeff Mesnil <[email protected]>
jmesnil added a commit to jmesnil/microprofile-config that referenced this issue Feb 11, 2019
Update the onAttributeChange method to return a ChangeSupport class that
can be used to handle release of resources (in the close method).

When a Config is released, it should call ChangeSupport.close to ensure
that the ConfigSource has a chance to properly release any resources
held by the callbacks.

* Add TCK test ConfigAccessorTest#testOnAttributeChange

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil
Copy link
Contributor

jmesnil commented Aug 2, 2019

@struberg is it still relevant? ConfigAccessor is already in the code base?

@jmesnil jmesnil closed this as completed Aug 2, 2019
@jmesnil jmesnil reopened this Aug 2, 2019
jmesnil pushed a commit to jmesnil/microprofile-config that referenced this issue Sep 6, 2019
jmesnil pushed a commit to jmesnil/microprofile-config that referenced this issue Sep 6, 2019
jmesnil pushed a commit to jmesnil/microprofile-config that referenced this issue Sep 6, 2019
jmesnil pushed a commit to jmesnil/microprofile-config that referenced this issue Sep 6, 2019
jmesnil pushed a commit to jmesnil/microprofile-config that referenced this issue Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants