-
Notifications
You must be signed in to change notification settings - Fork 51
Add deprecation/migration note to Databroker #762
Conversation
733c36a
to
2ce1a24
Compare
So maybe workflow should be "release in in new Repo first", then do the steps above? |
Yes, that works as well and is less ambiguous |
2ce1a24
to
d0905e0
Compare
Also prepare for 0.4.3
d0905e0
to
1ae62a6
Compare
@SebastianSchildt - a pre-release of https://github.com/eclipse-kuksa/kuksa-databroker/releases/tag/0.4.4 now exists, so now I think this one is ready for approval and merge |
Not sure, there was a very scary NOTICE.,d with lots of bullshit attached to the releases. I was thinking deleting the release, but for now just remove the file (I have a local copy). We should investigate where that came from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
I digged deeper on the Notice, it was just an super outdated file (that never made much sense anyway). So I "fixed" it here eclipse-kuksa/kuksa-databroker#13 but please check @erikbosch |
So are there any changes required in this PR/repo @SebastianSchildt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erikbosch . Not really. Yesterday I was just not sure, this is a bigger thing that will block us some time. So I think not. The release is "fixed", the other PR, we should merge sime time after.
So this one COULD be merged, I did not actually test /check the changes here so I can not "approve" just yet
I have done a smoke test, starting databroker+dtabroker-cli and made sure they can talk to each other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🦒
Intended workflow:
After that we may consider removing Databroker code from this repo
Note: This one shall maybe not be merged until we have performed sufficient testing on new repo, so that we can
release 0.4.4 in new repo at about the same time