This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
LOW-5 Malicious JWT access token can crash a thread of the databroker #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, some unit test would be good |
erikbosch
reviewed
Mar 25, 2024
| @@ -171,4 +177,34 @@ AEiqOjPq0D6X45wCzIwjILUCAwEAAQ== | |||
| Err(err) => panic!("decode should succeed but failed with:{}", err), | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_expiration_safe_addition() { | |||
There was a problem hiding this comment.
Would it possibly be useful with a small comment here specifying the purpose of the test, possibly something like "Rust can only handle date up to XXXX, verify that an error is reported if token expires in year 2424"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use safe addition
checked_addin decoder.rs to catch overflows and do notpanic. Instead returningClaimsError.