Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Add authorization integration test #708

Conversation

lukasmittag
Copy link
Contributor

This adds integration tests for authorizing against databroker and checking for the right permissions.
#675 needs to be merged first because it is based on the new client lib. Therefore also some changes in the existing integration test took place.

@lukasmittag lukasmittag force-pushed the feature/authorization_integration_test branch 2 times, most recently from f326915 to 9629dde Compare November 15, 2023 13:32
@lukasmittag lukasmittag force-pushed the feature/authorization_integration_test branch from b9001b4 to e130f4b Compare December 7, 2023 09:47
@lukasmittag
Copy link
Contributor Author

@sophokles73 if you want to take a look as well

erikbosch
erikbosch previously approved these changes Dec 7, 2023
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erikbosch
Copy link
Contributor

I looked at the Dash output and saw this.
Do we need to do anything?


[main] INFO Querying Eclipse Foundation for license data for 208 items.
[main] INFO Found 46 items.
[main] INFO Querying ClearlyDefined for license data for 162 items.
[main] INFO Found 162 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/kuksa/0.1.0
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@sophokles73
Copy link
Member

Do we need to do anything?

The Dash tool tries to find licensing information for dependencies on Clearly Defined and the Eclipse Foundation systems. The kuksa crate seems to not have been analyzed yet, neither by CD nor the EF.

What you could do is run the Dash tool with the --review switch to automatically create a corresponding review request with the EF. You would then need to provide the source location manually in the issue created in the EF GitLab instance for the review.

However, before you do so, you might want to think about

  • whether kuksa is the right name for the crate. IMHO it is quite abstract and can mean anything or nothing.
  • whether kuksa is actually a crate that is helpful to others as well and therefore should be published to crates.io

Copy link
Member

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianSchildt SebastianSchildt merged commit 1a3c946 into eclipse:master Dec 11, 2023
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants