Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

[databroker] Update dependencies to support RISC-V #694

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Oct 26, 2023

No description provided.

@argerus argerus mentioned this pull request Oct 26, 2023
@erikbosch
Copy link
Contributor

Cargo.lock needs to be regenerated as my Pr also touched cargo.lock

Update decoder to work with new version of jsonwebtoken.

"aud" should absolutely be checked, and we need to add support supplying
a set of valid audiences when running databroker.
@argerus argerus force-pushed the feature/risc_v_support branch from 8781069 to cab9238 Compare October 26, 2023 13:13
@SebastianSchildt
Copy link
Contributor

It builds for me, I was so far not b able to run it on milkv. But issue may be that milkv has an musl based "buildroot" system image, and the cross tooling could only build dynamically linked glibc version. I did copy all the required .so, but then I got this error

RUST_BACKTRACE=1 ./databroker
thread 'main' panicked at kuksa_databroker/databroker/src/[main.rs:446](http://main.rs:446/):7:
Failed building the Runtime: Os { code: 38, kind: Unsupported, message: "Function not implemented" }
stack backtrace:
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.
[root@milkv-duo]~#

(that is basically the last line of main.rs, so something already fails at early strtup I would say). On that platform (small root fs, less than 30MiB avaialable RAM :-P ) I could not run the debug build.

Anyway, I feel this might be more related to this special platform than the build. Will try on a Vision Five 2 once I find the time (that is far more powerful, and also has a more vanilla debian/ubuntu OS)

@SebastianSchildt
Copy link
Contributor

Did test on a VisionFive 2 (https://www.starfivetech.com/en/site/boards with some debian-ish OS), and it works. Started databroker on the target, and could connect dbcfeeder and client with subscription form another host. Seems to work. As this does update quite a bit of dependencies, let's merge this after next minor release is out. In case the dependecies updates breaks some minor things somewhere, we'll have some time to notice.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianSchildt SebastianSchildt merged commit e9c0981 into eclipse:master Oct 30, 2023
12 checks passed
@erikbosch erikbosch deleted the feature/risc_v_support branch October 31, 2024 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants