Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Better cmdline args specifying server in kuksa-client #658

Conversation

SebastianSchildt
Copy link
Contributor

Will close #657

This tries to simplify connecting to VSS servers using kuksa-client CLI. It uses URIs now, exmaples of valid URIs

grpc://127.0.0.1:55555
grpcs://127.0.0.1:55555
ws://127.0.0.1:8090
wss://127.0.0.1:8090

Other changes

  • Changed default (when no command line parameters are given) to connecting to databroker instead of val server
  • Removed the "set/getServerAddress" commands within the CLI, instead use `connect
  • Updated Readme

When checking this, please also double check whether all variants (TLS/noTLS databroker, val-server) still work.

This is a change in the CLI part only, so the API itself is unaffected

kuksa-client/README.md Outdated Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
@erikbosch
Copy link
Contributor

I have tested Databroker functionality, works fine. When this is merged we should update https://github.com/eclipse/kuksa.val/wiki/Release-Testing, or at least add a note that it needs to be updated (as part of preparation for next release)

kuksa-client/README.md Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
@SebastianSchildt SebastianSchildt force-pushed the feature/kuksa-client-better-cmdline-args branch from 2c7a1b1 to a433815 Compare September 18, 2023 15:37
@SebastianSchildt
Copy link
Contributor Author

Addressed findings. Somebody should still test if TLS and val-server connection works as expected

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basicallay looks better but two inor comments (see below)

kuksa-client/README.md Outdated Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
kuksa-client/README.md Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
kuksa-client/README.md Outdated Show resolved Hide resolved
@SebastianSchildt
Copy link
Contributor Author

Comments addressed. I added commits, so it is easier to see what I did. Once this is greenlighted might squash a little bit

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kuksa-client/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor documentation error, but when that is fixed I am happy to have it merged

@SebastianSchildt SebastianSchildt force-pushed the feature/kuksa-client-better-cmdline-args branch from 3b27221 to 00dd405 Compare September 21, 2023 07:50
@SebastianSchildt SebastianSchildt merged commit 1679357 into eclipse:master Sep 21, 2023
5 checks passed
@SebastianSchildt SebastianSchildt deleted the feature/kuksa-client-better-cmdline-args branch February 29, 2024 05:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kuksa-client uses cumbersome way to specify server
3 participants