-
Notifications
You must be signed in to change notification settings - Fork 51
Better cmdline args specifying server in kuksa-client #658
Better cmdline args specifying server in kuksa-client #658
Conversation
I have tested Databroker functionality, works fine. When this is merged we should update https://github.com/eclipse/kuksa.val/wiki/Release-Testing, or at least add a note that it needs to be updated (as part of preparation for next release) |
2c7a1b1
to
a433815
Compare
Addressed findings. Somebody should still test if TLS and val-server connection works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basicallay looks better but two inor comments (see below)
Comments addressed. I added commits, so it is easier to see what I did. Once this is greenlighted might squash a little bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor documentation error, but when that is fixed I am happy to have it merged
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
3b27221
to
00dd405
Compare
Will close #657
This tries to simplify connecting to VSS servers using kuksa-client CLI. It uses URIs now, exmaples of valid URIs
Other changes
When checking this, please also double check whether all variants (TLS/noTLS databroker, val-server) still work.
This is a change in the CLI part only, so the API itself is unaffected