This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Updated kuksa-client autocompletion #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argerus
force-pushed
the
feature/kuksa_client_autocompletion
branch
3 times, most recently
from
0efe894 to
37d9e4e
Compare
lukasmittag
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
LGTM, what I did is test it manually e.g. getValue Ve<TAB> and getValue Vehicle.<TAB> and works a s expected. I had just two minor comments. Also tried running against dtabroker v0.30.0 and behavior is as expected too. If I do
Test Client> getValue Vehicle.Trw<TAB>
Hint:
Path Path to be read
it shows the hint but I think thats okay and could be understood.
- Instead of listing the complete path for all path completions, only list the currently completable path components. - Only use columnar completion style. - Complete branches with a trailing '.' and leafs without. Co-authored-by: Lukas Mittag <[email protected]>
argerus
force-pushed
the
feature/kuksa_client_autocompletion
branch
from
045aff9 to
a811acd
Compare
|
Looks good to me, I think #650 can be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to the way autocompletion works in kuksa-client. Builds on top of the newly added support for
kuksa.val.v1by @rafaeling.