Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

make tls stuff optional #638

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Conversation

AkhilTThomas
Copy link
Contributor

the tonic feature "tls" is made optional.

Behavior:
cargo build --no-default-features --features=no-tls => builds databroker without tonic/tls or rust-tls dependencies
cargo build or cargo build --features=tls => build with tls features.

Dependencies can be verified by running and comparing
cargo tree --features no-tls --no-default-features > feat.txt
cargo tree --features tls > feat_tls.txt

@AkhilTThomas AkhilTThomas force-pushed the feat/optional_tls branch 3 times, most recently from f91abcd to bb9c9f8 Compare August 11, 2023 18:53
Signed-off-by: Akhil Thankachan Thomas <[email protected]>
kuksa_databroker/databroker/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Akhil Thankachan Thomas <[email protected]>
Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better :)

I just have one more suggestion, which is that command line arguments relating to TLS are removed when the feature is not enabled.

I implemented this on top of your branch, if you want to incorporate that commit directly.

@AkhilTThomas
Copy link
Contributor Author

Looks better :)

I just have one more suggestion, which is that command line arguments relating to TLS are removed when the feature is not enabled.

I implemented this on top of your branch, if you want to incorporate that commit directly.

* branch: https://github.com/boschglobal/kuksa.val/tree/argerus/optional_tls

* PR: [Remove TLS args when feature not enabled AkhilTThomas/kuksa.val#1](https://github.com/AkhilTThomas/kuksa.val/pull/1)

I have pulled your changes :)

@argerus argerus merged commit 42414cd into eclipse:master Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants