-
Notifications
You must be signed in to change notification settings - Fork 51
Introducing VSS 4.0 #549
Introducing VSS 4.0 #549
Conversation
data/vss-core/README.md
Outdated
@@ -9,6 +9,7 @@ In addition older versions may be supported. This folder contains copies of all | |||
|
|||
## Supported VSS versions | |||
|
|||
* [VSS 4.0](https://github.com/COVESA/vehicle_signal_specification/releases/tag/v4.0rc0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated when official release tagged
a69920a
to
cf66137
Compare
c41c336
to
6b0bf68
Compare
@@ -32,6 +32,8 @@ jobs: | |||
runs-on: ubuntu-latest | |||
|
|||
steps: | |||
- name: Query sites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be needed - otherwise builds fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Query sites" is a weird "name"
the "update" might be needed if the base iage for ubuntu:latest at GH is either so old, that referenced packages in the apt database don't exist anymore, of there is not apt db at all
I am currently not sure if the run stuff is executed in a shell, if it is, might be better to to change the run line of "installing JVM" to
run: sudo apt update && sudo apt-get install -y default-jre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing list of package information seemed to be outdated in previous builds, see e.g. https://github.com/eclipse/kuksa.val/actions/runs/5053685693/jobs/9067766790
I will put it within the same run
6b0bf68
to
3de010f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The databroker container still seems to come up with VSS 3.1.1 as a default?
I think becasue this
kuksa.val/kuksa_databroker/Dockerfile
Line 64 in 06cdbee
ADD ./data/vss-core/vss_release_3.1.1.json vss_release_3.1.1.json |
I suggest changing it to 4.0
(and maybe for convenience also still copying the 3.1.1, that would allow users to go back without needing to mount something. We might kick 3.1.1 out once 5 is in)
wdyt?
3de010f
to
10c4c01
Compare
Added 4.0 to Dockercontainer, kept 3.1.1. Reason why I missed that file was that I searched all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work for me 🛖
No description provided.