Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Introducing VSS 4.0 #549

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented May 5, 2023

No description provided.

@@ -9,6 +9,7 @@ In addition older versions may be supported. This folder contains copies of all

## Supported VSS versions

* [VSS 4.0](https://github.com/COVESA/vehicle_signal_specification/releases/tag/v4.0rc0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated when official release tagged

@erikbosch erikbosch force-pushed the erikbosch/erik_vss branch 13 times, most recently from a69920a to cf66137 Compare May 11, 2023 12:02
@erikbosch erikbosch marked this pull request as ready for review May 22, 2023 09:27
@erikbosch erikbosch force-pushed the erikbosch/erik_vss branch 3 times, most recently from c41c336 to 6b0bf68 Compare May 23, 2023 05:55
@@ -32,6 +32,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Query sites
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be needed - otherwise builds fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Query sites" is a weird "name"

the "update" might be needed if the base iage for ubuntu:latest at GH is either so old, that referenced packages in the apt database don't exist anymore, of there is not apt db at all

I am currently not sure if the run stuff is executed in a shell, if it is, might be better to to change the run line of "installing JVM" to

run: sudo apt update && sudo apt-get install -y default-jre

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing list of package information seemed to be outdated in previous builds, see e.g. https://github.com/eclipse/kuksa.val/actions/runs/5053685693/jobs/9067766790

I will put it within the same run

@erikbosch erikbosch force-pushed the erikbosch/erik_vss branch from 6b0bf68 to 3de010f Compare May 23, 2023 09:22
@erikbosch erikbosch changed the title Prepare for VSS 4.0 Introducing VSS 4.0 May 23, 2023
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The databroker container still seems to come up with VSS 3.1.1 as a default?

I think becasue this

ADD ./data/vss-core/vss_release_3.1.1.json vss_release_3.1.1.json
is not changed

I suggest changing it to 4.0

(and maybe for convenience also still copying the 3.1.1, that would allow users to go back without needing to mount something. We might kick 3.1.1 out once 5 is in)

wdyt?

@erikbosch erikbosch force-pushed the erikbosch/erik_vss branch from 3de010f to 10c4c01 Compare May 25, 2023 05:59
@erikbosch
Copy link
Contributor Author

Added 4.0 to Dockercontainer, kept 3.1.1. Reason why I missed that file was that I searched all *.* files for 3.1.1 and then I off course missed Dockerfile as it does not contain a dot. I have no strong opinion if we should keep old versions in docker containers or not. It could simplify life for PoC-setups.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work for me 🛖

@SebastianSchildt SebastianSchildt merged commit 9a4fe30 into eclipse:master May 25, 2023
@erikbosch erikbosch deleted the erikbosch/erik_vss branch February 27, 2024 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants