This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Limit contents copied when building kuksa-client container #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Jaegervall <[email protected]>
SebastianSchildt
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor improvement that could save some time for local builds of the kuksa-client docker container.
Without this change all content of current working directory is copied. That is typically not that much if starting on fresh clone, but if you have built e.g. databroker before you may copy a lot of unused data.
It has been verified that building and running containers works with this change.
COPY is typically preferred over DD, see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
Signed-off-by: Erik Jaegervall [email protected]