Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Update kuksa-viss-client to support Python 3.10 #340

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

erikbosch
Copy link
Contributor

SSH checks in Python 3.10 are stricter.
Using current version with Python 3.10 gives the following error:

Disconnected!! Cannot create a client socket with a PROTOCOL_TLS_SERVER context (_ssl.c:801)

This seems to be correct as CLIENT_AUTH used today is intended for server side sockets.

Changing to default context (i.e. implictly Purpose.SERVER_AUTH)

Also ignoring hostname check as default certificate does not include correct hostname

Disconnected!! [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: IP address mismatch, certificate is not valid for '127.0.0.1'. (_ssl.c:997)

Updating Docker build to use Python 3.10

Signed-off-by: Erik Jaegervall [email protected]

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container is not working for me

docker run --rm -it --net=host ttl.sh/kuksa.val/kuksa-client:8h
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/runpy.py", line 187, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/usr/local/lib/python3.10/runpy.py", line 146, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "/usr/local/lib/python3.10/runpy.py", line 110, in _get_module_details
    __import__(pkg_name)
  File "/kuksa_viss_client/kuksa_viss_client/__init__.py", line 27, in <module>
    from .KuksaWsComm import KuksaWsComm
  File "/kuksa_viss_client/kuksa_viss_client/KuksaWsComm.py", line 239
    // Certificates in ../kuksa_certificates does not contain the IP address used for
    ^^
SyntaxError: invalid syntax

//is not a vlid python comment :)

(hope is the right one, we should maybe label the ttl.sh uploads mor desintinvtively but it is a 3.10 version)

SSH checks in Python 3.10 are stricter.
Using current version with Python 3.10 gives the following error:

Disconnected!! Cannot create a client socket with a PROTOCOL_TLS_SERVER context (_ssl.c:801)

Changing to default context (i.e. implictly Purpose.SERVER_AUTH)
Also ignoring hostname check as certificate does not include correct hostname
Updating Docker build to use Python 3.10

Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch
Copy link
Contributor Author

Container is not working for me

Mea culpa, mea culpa, mea maxima culpa!

Should be fixed now

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better
lgtm

@SebastianSchildt SebastianSchildt merged commit 9c0d93e into eclipse:master Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants