Use references in validate function

eclipse · Jan 30, 2024 · fdc61db · fdc61db
1 parent 14217d8
commit fdc61db
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/kuksa_databroker/databroker/src/broker.rs b/kuksa_databroker/databroker/src/broker.rs
@@ -204,12 +204,12 @@ impl Entry {
         if let Some(datapoint) = &update.datapoint {
             self.validate_value(&datapoint.value)?;
             self.validate_allowed(&datapoint.value)?;
-            self.validate_timestamp(datapoint.ts)?;
+            self.validate_timestamp(&datapoint.ts)?;
         }
         if let Some(Some(actuatortarget)) = &update.actuator_target {
             self.validate_value(&actuatortarget.value)?;
             self.validate_allowed(&actuatortarget.value)?;
-            self.validate_timestamp(actuatortarget.ts)?;
+            self.validate_timestamp(&actuatortarget.ts)?;
         }
         if let Some(Some(updated_allowed)) = update.allowed.clone() {
             if Some(updated_allowed.clone()) != self.metadata.allowed {
@@ -561,12 +561,12 @@ impl Entry {
         }
     }
 
-    fn validate_timestamp(&self, timestamp: SystemTime) -> Result<(), UpdateError> {
-        if self.datapoint.ts > timestamp {
+    fn validate_timestamp(&self, timestamp: &SystemTime) -> Result<(), UpdateError> {
+        if self.datapoint.ts > *timestamp {
             return Err(UpdateError::TimestampTooOld);
         }
         if let Some(target) = &self.actuator_target {
-            if target.ts > timestamp {
+            if target.ts > *timestamp {
                 return Err(UpdateError::TimestampTooOld);
             }
         }
@@ -1768,7 +1768,6 @@ mod tests {
                 EntryType::Sensor,
                 "Test datapoint 1".to_owned(),
                 None,
-                None,
             )
             .await
             .expect("Register datapoint should succeed");
@@ -1781,7 +1780,6 @@ mod tests {
                 EntryType::Actuator,
                 "Test datapoint 2".to_owned(),
                 None,
-                None,
             )
             .await
             .expect("Register datapoint should succeed");
@@ -1804,7 +1802,6 @@ mod tests {
                     data_type: None,
                     description: None,
                     allowed: None,
-                    unit: None,
                 },
             )])
             .await
@@ -1824,7 +1821,6 @@ mod tests {
                     data_type: None,
                     description: None,
                     allowed: None,
-                    unit: None,
                 },
             )])
             .await
@@ -1844,7 +1840,6 @@ mod tests {
                     data_type: None,
                     description: None,
                     allowed: None,
-                    unit: None,
                 },
             )])
             .await
@@ -1875,7 +1870,6 @@ mod tests {
                     data_type: None,
                     description: None,
                     allowed: None,
-                    unit: None,
                 },
             )])
             .await