-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for equals() and forEach() on keySet() and entrySet(). #1678
Conversation
d2290ee
to
1345a5d
Compare
With the recent changes to make |
For sure! For context, I started working on #500 about 3 months ago, and I have lots of changes staged on a few branches, including lots of additional test coverage.
When I put stuff like this up for review, the reviews are too big to get anyone to read through. I'm finding them difficult to split up and land separately as well. Lots of the assertions that I pull up to superclasses expose real differences between the maps. None of them are earth shattering, but they slow me down.
I'm confident that immutable maps will never mutate through Entries, but it's possible they throw different exceptions from different maps. While I haven't pulled up tests of setValue() into the interface-based tests yet, there is already some coverage in the old-style tests. Line 439 in 9012729
|
976235f
to
3234c1a
Compare
3cefbab
to
47ba99a
Compare
47ba99a
to
77ad35a
Compare
610a31f
to
3a9cf81
Compare
3a9cf81
to
0ebe630
Compare
This one has been open for a while and just adds test coverage. Any objections to landing it? |
03f3227
to
b2c6180
Compare
b2c6180
to
ddb02d6
Compare
No description provided.