Replace usages of @Test(expected) with Assert.assertThrows(). #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
commented
May 17, 2024
| iterator.next(); | ||
| } | ||
| assertThrows(NoSuchElementException.class, () -> iterator.next()); | ||
| } |
There was a problem hiding this comment.
These overrides don't make sense - I'll remove them. The test is for non-empty-collection, and this overrides it to only make assertions about empty collections.
donraab
suggested changes
May 17, 2024
| public void get_throws_index_greater_than_size() | ||
| { | ||
| this.classUnderTest().get(this.classUnderTest().size()); | ||
| Assert.assertThrows(IndexOutOfBoundsException.class, () -> this.classUnderTest().get(this.classUnderTest().size())); |
There was a problem hiding this comment.
Do you not want to make this a static import since you are changing this anyway?
There was a problem hiding this comment.
Oh sure, it was like that in the original but I'll change it.
motlin
force-pushed
the
test-expected-exception
branch
from
f877789
to
acd17e5
Compare
motlin
commented
May 17, 2024
| } | ||
| iterator.next(); | ||
| } | ||
|
|
There was a problem hiding this comment.
this test is almost identical to the superclass, but it uses add() instead of a varargs creation method. Calling add() is the reason it doesn't work in unmodifiable tests which results in even more overrides.
motlin
force-pushed
the
test-expected-exception
branch
from
acd17e5
to
b9b786a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1578 and #1576. It turns out that just moving away from JUnit 4 syntax for expected exceptions is a fairly large change on its own. @Desislav-Petrov please take a look.