Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit5 Migration Part 1 - #1576 #1578

Conversation

Desislav-Petrov
Copy link
Contributor

@Desislav-Petrov Desislav-Petrov commented May 15, 2024

Part of the Junit5 migration preparation.

  • Moves imports to static to reduce change size for future PRs
  • Fixes a bug in an iterator test explained in here
  • Removes any junit4 syntax like @test(expected = ) as it's not supported in junit5

@Desislav-Petrov
Copy link
Contributor Author

@donraab @motlin hopefully this one is easier to review and is a good step towards the ultimate goal

@donraab
Copy link
Contributor

donraab commented May 16, 2024

Hi @Desislav-Petrov, thanks! I started taking a look and have a general question. It looks like only assertEquals and assertThrows are made static imports. Is it not necessary to make assertTrue, assertFalse, assertSame static imports as well?

@motlin
Copy link
Contributor

motlin commented May 17, 2024

I think we should land the three items separately. If you don't mind, I'll split this up into three separate PRs.

@donraab
Copy link
Contributor

donraab commented Sep 15, 2024

@Desislav-Petrov @motlin Is this PR still valid? It hasn't been updated since May. Please close if this is outdated now. Thanks!

@Desislav-Petrov
Copy link
Contributor Author

Not needed - closing, thx for flagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants