-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Conan recipe for VTD simulator #3
Conversation
1e90c28
to
f6dac19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some trouble installing and using cloe-launch. Let's have a look whether that's in scope of this PR or not.
@clssn, Neither pipx nor pip can install as editable a package that contains a See: pypa/pipx#151 |
8c6fb99
to
152254c
Compare
f2f8ddd
to
c1d8c19
Compare
I resolved all noted issues and rebased the branch. |
- This also involves rewriting the `vtd` script which is used to launch and terminate VTD. This script is now rewritten in Python and it creates a VTD sandbox first. This will probably be moved to the VTD Conan package itself in due time.
c1d8c19
to
449b5c9
Compare
This also allows us to run smoketests in the Docker container, since we no longer require VTD to be available to run the smoketests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cancelling obsolete review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 1 of 9 files at r5, 3 of 4 files at r6, 10 of 11 files at r7.
Reviewable status: 14 of 32 files reviewed, 2 unresolved discussions (waiting on @cassava and @clssn)
dist/docker/Dockerfile.archlinux, line 37 at r7 (raw file):
COPY . /cloe RUN make export-vendor export && \ make WITH_VTD=0 package-all && \
- Let's make an issue to use a WITH_VTD Dockerfile ARG defaulting to 0, same for other Dockerfiles
dist/docker/Dockerfile.ubuntu, line 62 at r7 (raw file):
make WITH_VTD=0 package-all && \ # Run smoketests. export LC_ALL=C.UTF-8 LANG=C.UTF-8 && \
- Add this to
Dockerfile.archlinux
449b5c9
to
1cc63c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 32 files reviewed, 3 unresolved discussions (waiting on @cassava and @clssn)
cli/Makefile, line 10 at r3 (raw file):
Previously, cassava (Ben Morgan) wrote…
Solved in the latest revision.
Done.
dist/docker/Dockerfile.archlinux, line 37 at r7 (raw file):
Previously, clssn (Henning Claßen) wrote…
- Let's make an issue to use a WITH_VTD Dockerfile ARG defaulting to 0, same for other Dockerfiles
Done.
dist/docker/Dockerfile.ubuntu, line 62 at r7 (raw file):
Previously, clssn (Henning Claßen) wrote…
- Add this to
Dockerfile.archlinux
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 11 files at r7, 1 of 1 files at r8.
Reviewable status: 15 of 32 files reviewed, 1 unresolved discussion (waiting on @cassava and @clssn)
Previously, we relied on a user-installed instance of VTD and used the environment variable
VTD_ROOT
to help us find this instance. By providing users a way to create a local Conan package, we achieve a better integration withcloe-launch
and the rest of the build system.This change is